Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and format some files #166

Closed
wants to merge 4 commits into from
Closed

Conversation

tobiasdiez
Copy link
Member

Run cleanup and format in eclipse on some files to make comparison in #162 easier.

@koppor
Copy link
Member

koppor commented Sep 17, 2015

Regarding the private final AbstractAction toggleGroups = new GeneralAction statements (see my second comment), you don't agree?

@matthiasgeiger
Copy link
Member

@koppor I agree. But I think, this behavior was introduced by a change you made in 77d1ea8 - using this setting IntelliJ creates endless lines using auto-format.

@tobiasdiez
Copy link
Member Author

I don't have a strong opinion about this. Sometimes it is more important to see what variables exists (then the new formatting is better) and sometimes you are more interested in how the initialization is done (then the old formatting is better). So should I revert this too?

@koppor
Copy link
Member

koppor commented Sep 17, 2015

Yeah. I thought, I did run the gradle formatter plugin, but it seems, it didn't touch that file somehow :(

@tobiasdiez Could you revert and add @Formatter:on/off strings? I prefer to see the initialization code 😇 That would really help!

@simonharrer
Copy link
Contributor

What is the current state of the eclipse xml @koppor @matthiasgeiger

@matthiasgeiger
Copy link
Member

Updated after discussion with @koppor in 0fd8a0c

@koppor
Copy link
Member

koppor commented Oct 20, 2015

As new formatter rules are in place, we should close this and follow up at #249.

@matthiasgeiger
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants